-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup for consul ent testing #1831
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
roncodingenthusiast
commented
Nov 7, 2023
•
edited
Loading
edited
- allow us to run consul with enterprise binary for testing enterprise feature
roncodingenthusiast
force-pushed
the
NET-5823
branch
from
November 7, 2023 16:24
368ad5f
to
ef188b1
Compare
roncodingenthusiast
force-pushed
the
NET-5823
branch
from
November 8, 2023 18:35
cbae257
to
0f9b4cf
Compare
roncodingenthusiast
requested review from
a team,
johnlanda and
kisunji
and removed request for
a team
November 8, 2023 18:40
roncodingenthusiast
force-pushed
the
NET-5823
branch
2 times, most recently
from
November 10, 2023 19:16
691c74d
to
238a39c
Compare
roncodingenthusiast
force-pushed
the
NET-5823
branch
from
November 10, 2023 19:24
238a39c
to
6c9f4ca
Compare
kisunji
approved these changes
Nov 14, 2023
johnlanda
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Regarding the latest
vs specific
versions, I lean towards always pinning things to a particular version in general. Feels like the more conservative approach even though it does mean some extra work to come and update as needed.
skpratt
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.